fix: Resolved the code quality issue#83
Merged
Merged
Conversation
Prekshith-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
nchandhi and
toherman-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes redundant exit(1) calls that immediately followed sys.exit(1) in two Fabric scripts, and adds the missing sys import to fabric_data_ingester.py to support its use of sys.exit.
Changes:
- Remove unreachable
exit(1)aftersys.exit(1)in two scripts. - Add
import systofabric_data_ingester.py.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| infra/scripts/fabric/fabric_database.py | Removes unreachable exit(1) following sys.exit(1). |
| infra/scripts/fabric/fabric_data_ingester.py | Adds import sys and removes unreachable exit(1) following sys.exit(1). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Roopan-Microsoft
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor improvement to error handling in the Fabric ingestion and database setup scripts by standardizing the way the script exits on errors.
fabric_data_ingester.pyandfabric_database.pyto usesys.exit(1)instead ofexit(1)for exiting on unexpected errors. This is a best practice for scripts and ensures consistent behavior. [1] [2]sysmodule infabric_data_ingester.pyto support this change.## PurposeDoes this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information